Add language option in settings menu #1990

srifqi · 2014-12-18T19:26:48Z

Rebase of #1937

PilzAdam · 2014-12-18T19:38:51Z

This is not correctly rebased (see the +<<<<<<< HEAD).

srifqi · 2014-12-18T19:41:24Z

Oops, missed that!
Will fix it as soon as possible.

EDIT: Can I just delete the +<<<<<<< HEAD, =======, >>>>>>> patch-4 and the old code (above =======)?

PilzAdam · 2014-12-18T22:09:06Z

Don't you test your code after rebasing? You should...

ShadowNinja · 2014-12-18T23:49:41Z

Please don't open new pull requests when rebasing.

srifqi · 2014-12-20T01:00:56Z

@PilzAdam Sorry, didn't test it.
@ShadowNinja Sorry, don't know that. How to rebase existing pull request?

srifqi · 2014-12-28T13:23:41Z

Okay, perfectly rebased. Thanks, @SmallJoker!

srifqi · 2015-02-19T12:21:33Z

Okay, merge conflicts again. :(
Need code change for the NEW layout.

nerzhul · 2015-02-19T13:10:34Z

builtin/mainmenu/tab_settings.lua

nerzhul · 2015-02-19T13:11:16Z

If you rebase this could be good for merge. I agree with this change but i need to test it after rebase

srifqi · 2015-03-01T09:12:30Z

Okay, updated to fit new 0.4.12's layout.

PS: @SmallJoker please rebase this!

srifqi · 2015-03-01T16:07:31Z

Thanks, @SmallJoker for the rebase!

Also, please update the translation (aka minetest.pot aka .po files) after merge.
As new word in this pr, Language:

EDIT: Found an error:
ERROR[main]: MSVC localization workaround active restating minetest in new environment!
Any chances of merge?

rubenwardy · 2015-03-04T15:29:24Z

+1 to idea. A check box in the top right may be better, just white text until you click it.

srifqi · 2015-03-05T07:39:50Z

@rubenwardy Sorry, what do you mean:

A check box in the top right may be better, just white text until you click it.

rubenwardy · 2015-03-05T17:37:35Z

srifqi · 2015-03-06T07:31:56Z

Okay, @rubenwardy
Thanks for ideas!
I'll update ASAP.

Wuzzy2 · 2015-03-06T09:55:28Z

I am opposed to this feature unless it allows the user to select “System language” as well (which just clears the language setting in minetest.conf), and this must be pre-selected at the first start.
So that Minetest will still start automatically in the system language in a sanely-configured operating system.

rubenwardy · 2015-03-06T10:43:26Z

@Wuzzy, of course that will still be the case.
On 6 Mar 2015 09:55, "Wuzzy" notifications@github.com wrote:

I am opposed to this feature unless it allows the user to select “System
language” as well (which just clears the language setting in minetest.conf),
and this must be pre-selected at the first start.
So that Minetest will still start automatically in the system language in
a sanely-configured operating system.

—
Reply to this email directly or view it on GitHub
#1990 (comment).

Wuzzy2 · 2015-03-06T10:53:37Z

Good. :-)

srifqi · 2015-03-07T06:37:09Z

@Wuzzy2, another good idea!
Let me check how to do that, or maybe any thoughts?

srifqi · 2015-03-12T12:43:11Z

@Wuzzy2 @rubenwardy
Sorry, do not know how to that maybe in another PR.
So, this PR is final. Merge?

ShadowNinja · 2015-03-31T04:57:21Z

builtin/mainmenu/tab_settings.lua

This doesn't account for things like the LANG env var which init_gettext does.

@ShadowNinja How to account things like the LANG env var?

EDIT: answered by @rubenwardy by using os.getenv()

makes the default selected language is based on LANG enviroment variable

srifqi · 2015-03-31T14:09:45Z

Okay, @ShadowNinja
Updated, as your request.
Will be squashed ~~soon~~ when fixed.

rubenwardy · 2015-03-31T14:11:55Z

Is it possible that os.getevn("LANG") returns nil?

srifqi · 2015-03-31T14:14:59Z

@rubenwardy Haven't tested. Should I add if statement?

Wuzzy2 · 2015-03-31T14:42:31Z

Is it possible that os.getevn("LANG") returns nil?

No, this code does not even work. :P

If you meant os.getenv("LANG"), then the answer is “Yes.”. Because environment variables such as LANG can certainly be not defined at all. Next time, refer to the Lua documentation. :P
But in the case of LANG, it is most likely a sign of a poorly configured system if this environment variable is not set.

srifqi · 2015-03-31T14:46:36Z

Then, should I add if statement?
Like this:

local LANG_env = os.getenv("LANG")
if LANG_env  == nil or LANG_env  == "" then
    LANG_env = "en"
end

rubenwardy · 2015-03-31T15:59:43Z

Wuzzy, that was obviously a typo. I read the documentation today when the
author asked how to read environment variables in #minetest-mods. I don't
appreciate your tone.

You might be able to do: (pseudo code)

setting or envLANG or "en"

Instead of an if statement, but I've never tried three in a row like that.

Wuzzy2 · 2015-03-31T17:16:39Z

I am not sure if it is so simple by just reading LANG and applying the value directly, even with nil check. I am not very familar with locales and stuff, sorry. :-(

For example, on my system, LANG contains de_DE.utf8.

mahmutelmas06 · 2015-06-24T17:18:58Z

Its better to restart game when language changed instead of showing a message.

MoNTE48 · 2015-09-11T05:26:22Z

2015-09-11 08:21:12: ERROR[main]: ========== ERROR FROM LUA ===========
2015-09-11 08:21:12: ERROR[main]: Failed to load and run script from 
2015-09-11 08:21:12: ERROR[main]: C:\Users\monte\Desktop\minetest-0.4.13\bin\..\builtin\init.lua:
2015-09-11 08:21:12: ERROR[main]: ...minetest-0.4.13\bin\..\builtin\mainmenu\tab_settings.lua:196: attempt to call field 'get_dirlist' (a nil value)
2015-09-11 08:21:12: ERROR[main]: stack traceback:
2015-09-11 08:21:12: ERROR[main]:   ...minetest-0.4.13\bin\..\builtin\mainmenu\tab_settings.lua:196: in main chunk
2015-09-11 08:21:12: ERROR[main]:   [C]: in function 'dofile'
2015-09-11 08:21:12: ERROR[main]:   ...Desktop\minetest-0.4.13\bin\..\builtin\mainmenu\init.lua:43: in main chunk
2015-09-11 08:21:12: ERROR[main]:   [C]: in function 'dofile'
2015-09-11 08:21:12: ERROR[main]:   ...rs\monte\Desktop\minetest-0.4.13\bin\..\builtin\init.lua:31: in main chunk
2015-09-11 08:21:12: ERROR[main]: ======= END OF ERROR FROM LUA ========
2015-09-11 08:21:12: ERROR[main]: No future without mainmenu

kilbith · 2015-10-17T21:19:47Z

@PilzAdam You can close this.

PilzAdam · 2015-10-18T08:56:03Z

006ef5b
This is the 6th issue closed by this commit. I'm really productive :D

srifqi · 2015-10-22T12:19:25Z

Okay,
At least, thanks for responding here.

Off-topic: But, I a little bit don't like the tree-like settings, How about more dialog? ... and some presets?

ShadowNinja added @ Client / Audiovisuals low-priority enhancement @ Translation Rebase needed The PR needs to be rebased by its author labels Dec 18, 2014

SmallJoker force-pushed the add_language_setting branch from ffbed93 to e733c05 Compare December 20, 2014 09:32

Zeno- removed the Rebase needed The PR needs to be rebased by its author label Dec 20, 2014

Zeno- mentioned this pull request Dec 20, 2014

Localization workaround active - Error #1996

Closed

kwolekr force-pushed the master branch from decd9c5 to 3f83ca2 Compare December 25, 2014 03:28

nerzhul reviewed Feb 19, 2015
View reviewed changes

builtin/mainmenu/tab_settings.lua Outdated

Copy link

Contributor

nerzhul Feb 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space

ShadowNinja changed the title ~~Add language setting~~ Add language option in settings menu Feb 21, 2015

SmallJoker force-pushed the add_language_setting branch 2 times, most recently from a6d554a to d7f2a2b Compare March 1, 2015 09:47

Add language option in setting tab

71fd338

srifqi force-pushed the add_language_setting branch from d7f2a2b to 71fd338 Compare March 26, 2015 12:46

ShadowNinja reviewed Mar 31, 2015
View reviewed changes

Apply @ShadowNinja's recomendation

38ed70a

makes the default selected language is based on LANG enviroment variable

est31 force-pushed the master branch from 1f1fb21 to a890c66 Compare August 2, 2015 17:10

PilzAdam closed this Oct 18, 2015

Add language option in settings menu #1990

Add language option in settings menu #1990

Uh oh!

Conversation

srifqi commented Dec 18, 2014

Uh oh!

PilzAdam commented Dec 18, 2014

Uh oh!

srifqi commented Dec 18, 2014

Uh oh!

PilzAdam commented Dec 18, 2014

Uh oh!

ShadowNinja commented Dec 18, 2014

Uh oh!

srifqi commented Dec 20, 2014

Uh oh!

srifqi commented Dec 28, 2014

Uh oh!

srifqi commented Feb 19, 2015

Uh oh!

nerzhul Feb 19, 2015

Choose a reason for hiding this comment

Uh oh!

nerzhul commented Feb 19, 2015

Uh oh!

srifqi commented Mar 1, 2015

Uh oh!

srifqi commented Mar 1, 2015

Uh oh!

rubenwardy commented Mar 4, 2015

Uh oh!

srifqi commented Mar 5, 2015

Uh oh!

rubenwardy commented Mar 5, 2015

Uh oh!

srifqi commented Mar 6, 2015

Uh oh!

Wuzzy2 commented Mar 6, 2015

Uh oh!

rubenwardy commented Mar 6, 2015

Uh oh!

Wuzzy2 commented Mar 6, 2015

Uh oh!

srifqi commented Mar 7, 2015

Uh oh!

srifqi commented Mar 12, 2015

Uh oh!

ShadowNinja Mar 31, 2015

Choose a reason for hiding this comment

Uh oh!

srifqi Mar 31, 2015

Choose a reason for hiding this comment

Uh oh!

srifqi commented Mar 31, 2015

Uh oh!

rubenwardy commented Mar 31, 2015

Uh oh!

srifqi commented Mar 31, 2015

Uh oh!

Wuzzy2 commented Mar 31, 2015

Uh oh!

srifqi commented Mar 31, 2015

Uh oh!

rubenwardy commented Mar 31, 2015

Uh oh!

Wuzzy2 commented Mar 31, 2015

Uh oh!

mahmutelmas06 commented Jun 24, 2015

Uh oh!

MoNTE48 commented Sep 11, 2015

Uh oh!

kilbith commented Oct 17, 2015

Uh oh!

PilzAdam commented Oct 18, 2015

Uh oh!

srifqi commented Oct 22, 2015

Uh oh!

Reviewers

Assignees

Labels