Improve Object Download #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
harshavardhana,
Alevsk,
adfost,
bexsoft and
jinapurapu
harshavardhana
requested changes
Jul 14, 2021
bexsoft
requested changes
Jul 15, 2021
|
@bexsoft this feature doesn't work through the React development server, try this using the final go server with the commited assets on port |
I see, please add this information to the PR to avoid confusion |
|
@bexsoft done |
bexsoft
requested changes
Jul 15, 2021
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
|
@bexsoft done |
bexsoft
approved these changes
Jul 15, 2021
harshavardhana
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces native browser file download behavior
Test this using only the go server, since the react server won't proxy the request properly
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com