RST-7753 Updating part_payment banner based on the part_payment outcome (#2311)

zaparka · web-flow · commit ed85be6688cd · 2025-12-16T09:53:03.000Z
diff --git a/app/models/views/application_result.rb b/app/models/views/application_result.rb
@@ -12,6 +12,22 @@ def result
       ['granted', 'full', 'part', 'paid', 'none', 'return'].include?(outcome) ? outcome : 'error'
     end
 
+    def banner_style
+      if processed_part_payment?
+        @application.decision
+      else
+        result
+      end
+    end
+
+    def pp_outcome
+      if part_payment_successful
+        'paid'
+      else
+        @application.part_payment&.outcome
+      end
+    end
+
     def amount_to_pay
       # Because we are outside the ActiveRecord::Base scope I can't use is_a?
       if outcome_from.class.name.to_s == 'PartPayment'
@@ -55,6 +71,11 @@ def amount_to_refund
       @application.detail.fee - amount_to_pay_for_part_payment.to_f
     end
 
+    def processed_part_payment?
+      return false if @application.part_payment.nil?
+      @application.processed?
+    end
+
     delegate :state, to: :@application
 
     def return_type
diff --git a/app/views/shared/_remission_type.html.slim b/app/views/shared/_remission_type.html.slim
@@ -1,7 +1,9 @@
-#result.callout class="callout-#{source.result}"
+#result.callout class="callout-#{source.try(:banner_style) || source&.result}"
   - if source.try(:evidence)
     h2.govuk-heading-l = t("remissions.#{source.result}_html", amount_to_pay: source.amount_to_pay, return_type: source.return_type)
   - elsif source.try(:refund) && source.result != 'none'
     h2.govuk-heading-l =t("remissions.part_refund_html", amount_to_pay: "£#{parse_amount_to_pay(source.amount_to_refund)}")
+  - elsif source.try(:processed_part_payment?)
+    h2.govuk-heading-l = t("remissions.#{source.pp_outcome}_html", amount_to_pay: source.amount_to_pay, return_type: source.return_type)
   - else
     h2.govuk-heading-l =t("remissions.#{source.result}_html", amount_to_pay: source.amount_to_pay, return_type: source.return_type)
diff --git a/spec/models/views/application_result_spec.rb b/spec/models/views/application_result_spec.rb
@@ -222,4 +222,88 @@
       it { is_expected.to eql('payment') }
     end
   end
+
+  describe '#processed_part_payment?' do
+    subject { view.processed_part_payment? }
+
+    context 'when the application has a part payment and is processed' do
+      let(:part_payment) { build_stubbed(:part_payment) }
+      let(:application) { build_stubbed(:application, part_payment: part_payment, state: 3) }
+
+      it { is_expected.to be true }
+    end
+
+    context 'when the application has no part payment' do
+      let(:application) { build_stubbed(:application, part_payment: nil, state: 3) }
+
+      it { is_expected.to be false }
+    end
+
+    context 'when the application is not processed' do
+      let(:part_payment) { build_stubbed(:part_payment) }
+      let(:application) { build_stubbed(:application, part_payment: part_payment, state: 2) }
+
+      it { is_expected.to be false }
+    end
+  end
+
+  describe '#banner_style' do
+    subject { view.banner_style }
+
+    context 'when the application has a processed part payment' do
+      let(:part_payment) { build_stubbed(:part_payment) }
+      let(:application) { build_stubbed(:application, part_payment: part_payment, state: 3, decision: 'full', outcome: 'part') }
+
+      it 'returns the application decision' do
+        is_expected.to eq 'full'
+      end
+    end
+
+    context 'when the application has no part payment' do
+      let(:application) { build_stubbed(:application, part_payment: nil, outcome: 'granted') }
+
+      it 'returns the result' do
+        is_expected.to eq 'granted'
+      end
+    end
+
+    context 'when the application is not processed' do
+      let(:part_payment) { build_stubbed(:part_payment) }
+      let(:application) { build_stubbed(:application, part_payment: part_payment, state: 2, decision: 'none', outcome: 'part') }
+
+      it 'returns the result' do
+        is_expected.to eq 'part'
+      end
+    end
+  end
+
+  describe '#pp_outcome' do
+    subject { view.pp_outcome }
+
+    context 'when the part payment is successful' do
+      let(:part_payment) { build_stubbed(:part_payment, correct: true, outcome: 'part') }
+      let(:application) { build_stubbed(:application, part_payment: part_payment) }
+
+      it 'returns paid' do
+        is_expected.to eq 'paid'
+      end
+    end
+
+    context 'when the part payment is not successful' do
+      let(:part_payment) { build_stubbed(:part_payment, correct: false, outcome: 'none') }
+      let(:application) { build_stubbed(:application, part_payment: part_payment) }
+
+      it 'returns the part payment outcome' do
+        is_expected.to eq 'none'
+      end
+    end
+
+    context 'when there is no part payment' do
+      let(:application) { build_stubbed(:application, part_payment: nil) }
+
+      it 'returns nil' do
+        is_expected.to be_nil
+      end
+    end
+  end
 end
