Alcotest.run: ensure and_exit and record_backtrace can be overriden for the test sub-command too

edwintorok · edwintorok · commit 6199ef14acd0 · 2026-05-11T11:23:17.000+01:00
`default_cmd` handles this correctly, but `test_cmd` always set `and_exit` and `record_backtrace` to `true`. Due to `Config.User.(cli_config || config)` this meant that `and_exit` couldn't be set to `false` by the caller. The main program may want to set `and_exit` to false if it has some wrappers using `Fun.protect` for example, with `and_exit` set to true these wouldn't run. For backwards compatibility with old versions of alcotest one workaround is to use `at_exit` instead of `Fun.protect` to register cleanup handlers. Fixes #438 Signed-off-by: Edwin Török <edwin@tarides.com>
diff --git a/src/alcotest-engine/cli.ml b/src/alcotest-engine/cli.ml
@@ -125,12 +125,14 @@ module Make (P : Platform.MAKER) (M : Monad.S) :
   let test_cmd config args library_name tests =
     let ci = Config.User.ci config
     and stdout = Config.User.stdout config
+    and and_exit = Config.User.and_exit config
+    and record_backtrace = Config.User.record_backtrace config
     and stderr = Config.User.stderr config in
     let doc = "Run a subset of the tests." in
     let term =
       let+ () = set_color stdout stderr
       and+ cli_config =
-        Config.User.term ~stdout ~stderr ~and_exit:true ~record_backtrace:true
+        Config.User.term ~stdout ~stderr ~and_exit ~record_backtrace
           ~ci
       and+ args = args in
       let config = Config.User.(cli_config || config) in
