Add edge case tests for inline_contents_max_bytes

balat · mistral-vibe · balat · commit 110ee236fed8 · 2026-04-03T14:10:34.000+02:00
Add tests for boundary conditions of the inline_contents_max_bytes
configuration:

1. Zero threshold: Verifies that threshold=0 properly disables inlining
2. Large threshold: Verifies that large but valid thresholds work correctly

These tests ensure robust handling of edge cases and complement the
existing validation test for negative values.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe &lt;vibe@mistral.ai&gt;
diff --git a/test/irmin-pack/test_inline_contents.ml b/test/irmin-pack/test_inline_contents.ml
@@ -35,10 +35,11 @@ module S = struct
   include Maker.Make (Schema)
 end
 
-let config ~sw ~fs ?(readonly = false) ?(fresh = true) ~inline_contents root =
+let config ~sw ~fs ?(readonly = false) ?(fresh = true)
+    ?inline_contents_max_bytes ~inline_contents root =
   Irmin_pack.config ~sw ~fs ~readonly ~fresh
     ~indexing_strategy:Irmin_pack.Indexing_strategy.minimal ~inline_contents
-    root
+    ?inline_contents_max_bytes root
 
 let info = S.Info.empty
 
@@ -318,7 +319,9 @@ end
 (** Test that negative inline_contents_max_bytes raises an error *)
 let test_negative_inline_threshold ~fs () =
   Alcotest.check_raises "negative inline threshold should raise"
-    (Invalid_argument "Irmin_pack.Conf: inline_contents_max_bytes must be non-negative")
+    (Invalid_argument
+       "Irmin_pack.Conf: inline_contents_max_bytes must be non-negative (got \
+        -1)")
     (fun () ->
       let root = Eio.Path.(fs / "_build" / "test-inline-negative") in
       Eio.Switch.run @@ fun sw ->
@@ -329,6 +332,28 @@ let test_negative_inline_threshold ~fs () =
       in
       ())
 
+(** Test that zero inline_contents_max_bytes disables inlining *)
+let test_zero_inline_threshold ~fs () =
+  let root = Eio.Path.(fs / "_build" / "test-inline-zero") in
+  rm_dir root;
+  Eio.Switch.run @@ fun sw ->
+  let repo =
+    S.Repo.v
+      (config ~sw ~fs ~readonly:false ~fresh:true ~inline_contents:true
+         ~inline_contents_max_bytes:0 root)
+  in
+  (* With threshold=0, no content should be inlined *)
+  let tree = S.Tree.empty () in
+  let tree = S.Tree.add tree [ "small" ] "abc" in
+  let commit = S.Commit.v repo ~parents:[] ~info tree in
+  let hash = S.Commit.hash commit in
+  (* Read back and verify *)
+  let commit' = S.Commit.of_hash repo hash |> Option.get in
+  let tree' = S.Commit.tree commit' in
+  let small = S.Tree.find tree' [ "small" ] in
+  Alcotest.(check (option string)) "small content" (Some "abc") small;
+  S.Repo.close repo
+
 let tests ~fs =
   let tc name f = Alcotest.test_case name `Quick f in
   [
@@ -338,5 +363,8 @@ let tests ~fs =
     tc "inlining structure" (test_inlining_structure ~fs);
     tc "inlining with non-default metadata"
       (Test_metadata.test_inlining_with_metadata ~fs);
-    tc "negative inline threshold raises error" (test_negative_inline_threshold ~fs);
+    tc "negative inline threshold raises error"
+      (test_negative_inline_threshold ~fs);
+    tc "zero inline threshold disables inlining"
+      (test_zero_inline_threshold ~fs);
   ]
