Add Win32 support #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we want to open the file in raw mode to behave more like a Xen unikernel, where - data is persisted as soon as `write` returns (and not pending in some write back cache) - data is only copied if we ask for it (and are happy with the implications) - caches are only used if they're linked into the program On Linux and OSX it's quite straightforward to open files in raw mode with flags O_DIRECT and F_NOCACHE. On Win32 the APIs are completely different. As an initial starting point, this patch adds a Win32 implementation which opens the file as normal but calls `fsync` after every `write`. This gains the persistence property, but still causes data to be copied and cached. Signed-off-by: David Scott <dave.scott@docker.com>
Only Unix has the notion of a block device as a file; Windows will never need a `blkgetsize64`. Signed-off-by: David Scott <dave.scott@docker.com>
This removes the only deprecation warning. Signed-off-by: David Scott <dave.scott@docker.com>
This is simpler and more portable. Note that `ftruncate` isn't implemented in Lwt for Win32, see mirage#42. Signed-off-by: David Scott <dave.scott@docker.com>
See mirage#42 Signed-off-by: David Scott <dave.scott@docker.com>
Member
Author
|
Appveyor only failed because it isn't configured yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsyncrather thanopenwithO_DIRECTblkgetsize64since there are no block device filesopen,lseek,writeinstead ofddin the testsresizeunimplemented for now