This repository was archived by the owner on Jan 28, 2020. It is now read-only.
Removed export view which isn't used anymore #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisecapella
force-pushed
the
refactor/gs/remove_export_view
branch
from
7cadac4 to
29653b0
Compare
noisecapella
force-pushed
the
refactor/gs/remove_export_view
branch
from
29653b0 to
aed8720
Compare
|
Following what @pdpinch said yesterday, you should also open an issue for what you are solving here |
|
other than that, if the tests pass, it can be merged |
|
Ok, I added an issue and the 'Fixes' thing above |
There was a problem hiding this comment.
not sure it's a good practice, but for debugging reasons (at least) it would be a good idea to have the learning resource id somewhere, so what about having the href="#<lr_id>"?
There was a problem hiding this comment.
It's stored in the data-learningresource-id attribute
|
The functionality is intact so looks good to me |
giocalitri
added a commit
that referenced
this pull request
Jul 23, 2015
Removed export view which isn't used anymore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408