Skip to content
This repository was archived by the owner on Jan 28, 2020. It is now read-only.

Conversation

noisecapella
Copy link
Contributor

Fixes #770

@jamiefolsom
Copy link
Contributor

I'll look at this one.

@jamiefolsom
Copy link
Contributor

  • Functionality
  • Code
  • Tests pass
  • Questions

@jamiefolsom
Copy link
Contributor

@noisecapella -- should we set the active tab in the panel to the vocabulary tab every time we load the panel, so that XML is not loaded unless explicitly requested?

Steps: First time I click on an LR, the panel opens, with vocab active. All good. Click on XML tab. Then close the panel. Then open another LR, and the XML tab is still selected. Might be we're loading that content too eagerly.

@noisecapella
Copy link
Contributor Author

That's a good idea, I'll make that change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add a newline here.

@jamiefolsom
Copy link
Contributor

General comment, perhaps unavoidable, but listing.js is getting hard to navigate, at almost 600 lines of js. Time to consider refactoring it?

@noisecapella
Copy link
Contributor Author

Already doing it #797

@jamiefolsom
Copy link
Contributor

Cool.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this...

@jamiefolsom
Copy link
Contributor

All my notes are optional. Looks good and works well. 👍 from me.

@noisecapella noisecapella force-pushed the feature/gs/lazy_load_tab branch from 68bc23b to 32de1e4 Compare October 23, 2015 20:43
@noisecapella noisecapella force-pushed the feature/gs/lazy_load_tab branch from 32de1e4 to 01b16e0 Compare October 23, 2015 20:44
@noisecapella
Copy link
Contributor Author

Ok, it should now load the resource tab whenever the panel opens

@jamiefolsom
Copy link
Contributor

Nice. Works well. 👍

noisecapella pushed a commit that referenced this pull request Oct 23, 2015
Implemented lazy loading for resource tab
@noisecapella noisecapella merged commit a31a9a3 into master Oct 23, 2015
@noisecapella noisecapella deleted the feature/gs/lazy_load_tab branch October 23, 2015 21:02
@pwilkins pwilkins modified the milestone: Release v0.13.0 Oct 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants