-
Notifications
You must be signed in to change notification settings - Fork 6
Implemented lazy loading for resource tab #794
Conversation
3f67d76
to
68bc23b
Compare
I'll look at this one. |
|
@noisecapella -- should we set the active tab in the panel to the vocabulary tab every time we load the panel, so that XML is not loaded unless explicitly requested? Steps: First time I click on an LR, the panel opens, with vocab active. All good. Click on XML tab. Then close the panel. Then open another LR, and the XML tab is still selected. Might be we're loading that content too eagerly. |
That's a good idea, I'll make that change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add a newline here.
General comment, perhaps unavoidable, but listing.js is getting hard to navigate, at almost 600 lines of js. Time to consider refactoring it? |
Already doing it #797 |
Cool. |
ui/static/ui/js/listing.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this...
All my notes are optional. Looks good and works well. 👍 from me. |
68bc23b
to
32de1e4
Compare
32de1e4
to
01b16e0
Compare
Ok, it should now load the resource tab whenever the panel opens |
Nice. Works well. 👍 |
Implemented lazy loading for resource tab
Fixes #770