Skip to content

Conversation

@ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Jun 17, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/4591

Description (What does it do?)

Adds a signup popover to

  • channel page "Subscribe" button
  • Resource card "action" buttons [TODO]

Screenshots (if appropriate):

Screenshot 2024-06-18 at 5 05 03 PM Screenshot 2024-06-18 at 5 05 15 PM Screenshot 2024-06-18 at 4 52 37 PM Screenshot 2024-06-18 at 4 31 21 PM Screenshot 2024-06-18 at 4 52 52 PM Screenshot 2024-06-18 at 4 53 51 PM

How can this be tested?

  1. Check Cards on homepage, search page, and channel pages:
    • Click the "Add to list" buttons as an authenticated user (staff or otherwise). There should be no changes:
      • Bookmark = "Add to user list"
      • Itemized list = "Add to learning path"
    • As an unauthenticated user, you should only see the bookmark button, and it should open a popover prompting signup.
  2. Check "Subscribe" button on channel pages, e.g., http://localhost:8063/c/unit/ocw
    • authenticated users: Subscribe / unsubscribe functions as before
    • unauthenticated users get the popover for signup.
  3. http://localhost:6006/?path=/story/smoot-design-popover--basic and the adjacent two popover stories are worht looking at i guess.

@ChristopherChudzicki ChristopherChudzicki changed the title Cc/signup popover Signup Popover Jun 17, 2024
@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Jun 18, 2024
@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review June 19, 2024 00:49
@shanbady shanbady self-requested a review June 20, 2024 11:25
@shanbady shanbady self-assigned this Jun 20, 2024
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing i noticed is that the sign up url doesnt appear to redirect to the page that the user left off at (the sign up/log in in the header does)

const SignupPopover: React.FC<SignupPopoverProps> = (props) => {
return (
<StyledPopover {...props} open={!!props.anchorEl}>
<HeaderText variant="subtitle2">Join MIT Open for free</HeaderText>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jon has just (a minute ago) merged in a PR that standardizes the value for the site name. probably worth rebasing and integrating that here.

@shanbady shanbady added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Jun 20, 2024
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@ChristopherChudzicki ChristopherChudzicki merged commit 6bd94fa into main Jun 20, 2024
@odlbot odlbot mentioned this pull request Jun 20, 2024
11 tasks
@rhysyngsun rhysyngsun deleted the cc/signup-popover branch February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants