-
Notifications
You must be signed in to change notification settings - Fork 3
Signup Popover #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup Popover #1109
Conversation
0c0fe63 to
853a69d
Compare
853a69d to
8bf8db5
Compare
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing i noticed is that the sign up url doesnt appear to redirect to the page that the user left off at (the sign up/log in in the header does)
| const SignupPopover: React.FC<SignupPopoverProps> = (props) => { | ||
| return ( | ||
| <StyledPopover {...props} open={!!props.anchorEl}> | ||
| <HeaderText variant="subtitle2">Join MIT Open for free</HeaderText> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jon has just (a minute ago) merged in a PR that standardizes the value for the site name. probably worth rebasing and integrating that here.
8bf8db5 to
11a680b
Compare
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4591
Description (What does it do?)
Adds a signup popover to
Screenshots (if appropriate):
How can this be tested?