Update the conditional for the marketing image chooser #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… haven't seen a marketing image at all yet
jkachel
added
Needs Review
ChristopherChudzicki
approved these changes
Jun 18, 2024
Contributor
ChristopherChudzicki
left a comment
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
Approving this because it fixes the infinite loop in our tests.
It does have an issue which james is going to fix in a followup PR.
Screen.Recording.2024-06-18.at.9.15.04.AM.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes mitodl/hq#4635
Description (What does it do?)
The
generateMarketingImageSrcuses a do..while to re-select a random marketing image if the image that we just displayed to the user is the one that gets selected again. This also needed to drop out of the loop if there wasn't a last marketing image, so now it does.How can this be tested?
Automated tests should pass. No real front-end change should be seen - the homepage should load and your testimonials images should be randomized and shouldn't repeat back-to-back (they will still repeat in the list as a whole).