Square aspect ratio for media resource images #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkafton
commented
Jun 27, 2024
| })) | ||
| const MediaCarousel = styled(ResourceCarousel)(({ theme }) => ({ | ||
| margin: "80px 0", | ||
| minHeight: "388px", |
Contributor
Author
There was a problem hiding this comment.
This preserves the height of the section as it was collapsing as I tabbed through the media types, though we may want to do this in the carousel itself.
Contributor
|
@steven-hatch fyi ☝️ What was your expectation for media cards and course/program cards being mixed on the same carousel? Jon's solution—make the square aspect ratio opt in, and only use it where we know all cards are media—seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4523
Description (What does it do?)
Displays media resource (podcast episodes, videos) images tn the homepage Media section carousel with square aspect ratios.
Screenshots (if appropriate):
How can this be tested?
Navigate to homepage. Check resource cards in the Media section have images with aspect ratio 1 and that their loading state reflects loaded proportions. Check that other resource cards are not affected.
Additional Context
isMediaprop to theLearningResourceCard.Opted to do this by configuration because although we can detect that a resource is media by its resource type (
podcast,podcast_episode,video), if we do that at the card level we end up with these: