Scroll results into view when paginating #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkafton
force-pushed
the
jk/4741-scroll-on-paginate
branch
from
aa982ba to
937b322
Compare
rhysyngsun
requested changes
Jun 28, 2024
Contributor
rhysyngsun
left a comment
rhysyngsun
left a comment
There was a problem hiding this comment.
Functionality looks good, just one piece of feedback.
| setSearchParams, | ||
| }) => { | ||
| const [searchParams] = useSearchParams() | ||
| const scrollHook = useRef<HTMLInputElement>(null) |
Contributor
There was a problem hiding this comment.
I think this should just be HTMLElement because it's a div
Contributor
Author
There was a problem hiding this comment.
Good spot, thanks.
rhysyngsun
added
Waiting on author
and removed
Needs Review
Comment on lines
+686
to
+691
| setTimeout(() => { | ||
| scrollHook.current?.scrollIntoView({ | ||
| block: "center", | ||
| behavior: "smooth", | ||
| }) | ||
| }, 0) |
Contributor
There was a problem hiding this comment.
Out of curiosity... why wrap this in setTimeout?
Contributor
Author
There was a problem hiding this comment.
Despite some investigating, all I can say for sure is that it doesn't work without it. Likely some nuance around the dom element not being available during the old render cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4741
Description (What does it do?)
Scrolls the top of the search results to the center of the page on pagination.
Screenshots (if appropriate):
Screen.Recording.2024-06-28.at.15.35.18.mov
How can this be tested?
Navigate to the search page or a unit page and paginate through search results.