Skip to content

Conversation

@ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

Toward https://github.com/mitodl/hq/issues/4760

Description (What does it do?)

This PR removes our existing gh-pages publishing step. You can see at https://mitodl.github.io/mit-open/ that it's not working, but it runs on every PR. I'd like to stop running it while I debug this.

How can this be tested?

Tests should pass

name: playwright-report
path: e2e_testing/playwright-report

publish-pages:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left in-place the step that builds storybook above.

@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review June 28, 2024 20:09
@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Jun 28, 2024
Copy link
Contributor

@rhysyngsun rhysyngsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhysyngsun rhysyngsun added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Jun 28, 2024
@ChristopherChudzicki ChristopherChudzicki merged commit 4b4bcb8 into main Jun 28, 2024
This was referenced Jul 1, 2024
@rhysyngsun rhysyngsun deleted the cc/stop-publishing-pages-every-pr branch February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants