Skip to content

Conversation

@gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Jun 28, 2024

What are the relevant tickets?

https://github.com/mitodl/hq/issues/4748

Description (What does it do?)

This PR updates unit names in offered_by.json and platforms.json according to what is described in the attached issue.

How can this be tested?

  • Spin up mit-open on this branch
  • Run the following commands, one at a time:
docker compose exec web ./manage.py loaddata platforms offered_by
docker compose exec web ./manage.py update_offered_by
docker compose exec web ./manage.py update_platforms
docker compose exec web ./manage.py backpopulate_resource_channels --overwrite
docker compose exec web ./manage.py recreate_index --all
  • After all of the commands above have been run successfully, test the following:

Checklist:

  • After the code is deployed to each environment, run the following in a Heroku shell (heroku run -a <app name> /bin/bash):
    • ./manage.py loaddata platforms offered_by
    • ./manage.py update_offered_by
    • ./manage.py update_platforms
    • ./manage.py backpopulate_resource_channels --overwrite
    • ./manage.py recreate_index --all

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label Jun 28, 2024
@gumaerc gumaerc force-pushed the cg/update-unit-names branch from 57269c5 to 780cbe4 Compare June 28, 2024 20:24
export const PLATFORMS: Record<PlatformEnum, PlatformObject> = {
[PlatformEnum.Ocw]: {
name: "OCW",
name: "MIT OpenCourseware",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll triple-check with OCW, but I've never seen it with a lower-case w

Suggested change
name: "MIT OpenCourseware",
name: "MIT OpenCourseWare",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did it that way because that's the way it's written in the issue, but if the W should be capitalized I'll do that.


mitx = "MITx"
ocw = "OCW"
ocw = "MIT OpenCourseware"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ocw = "MIT OpenCourseware"
ocw = "MIT OpenCourseWare"


edx = "edX"
ocw = "OCW"
ocw = "MIT OpenCourseware"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ocw = "MIT OpenCourseware"
ocw = "MIT OpenCourseWare"

"model": "learning_resources.LearningResourceOfferor",
"fields": {
"name": "OCW",
"name": "MIT OpenCourseware",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "MIT OpenCourseware",
"name": "MIT OpenCourseWare",

"fields": {
"code": "ocw",
"name": "OCW",
"name": "MIT OpenCourseware",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "MIT OpenCourseware",
"name": "MIT OpenCourseWare",

ocw = "OCW"
ocw = "MIT OpenCourseWare"
bootcamps = "Bootcamps"
xpro = "xPRO"
Copy link
Member

@pdpinch pdpinch Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to change this while we're here. I'll try to confirm.

Suggested change
xpro = "xPRO"
xpro = "MIT xPRO"

Yeah, this must have been an oversight in the doc we were given. See https://openlearning.mit.edu/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. When you're able to confirm it update the issue and I'll change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and I updated the issue. Sorry again for this oversight.

Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@gumaerc gumaerc force-pushed the cg/update-unit-names branch from 33cf325 to a5c4e54 Compare July 1, 2024 18:25
@gumaerc gumaerc merged commit 21c02c2 into main Jul 1, 2024
@odlbot odlbot mentioned this pull request Jul 1, 2024
19 tasks
@rhysyngsun rhysyngsun deleted the cg/update-unit-names branch February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants