-
Notifications
You must be signed in to change notification settings - Fork 3
update unit names #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update unit names #1198
Conversation
57269c5 to
780cbe4
Compare
| export const PLATFORMS: Record<PlatformEnum, PlatformObject> = { | ||
| [PlatformEnum.Ocw]: { | ||
| name: "OCW", | ||
| name: "MIT OpenCourseware", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll triple-check with OCW, but I've never seen it with a lower-case w
| name: "MIT OpenCourseware", | |
| name: "MIT OpenCourseWare", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did it that way because that's the way it's written in the issue, but if the W should be capitalized I'll do that.
learning_resources/constants.py
Outdated
|
|
||
| mitx = "MITx" | ||
| ocw = "OCW" | ||
| ocw = "MIT OpenCourseware" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ocw = "MIT OpenCourseware" | |
| ocw = "MIT OpenCourseWare" |
learning_resources/constants.py
Outdated
|
|
||
| edx = "edX" | ||
| ocw = "OCW" | ||
| ocw = "MIT OpenCourseware" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ocw = "MIT OpenCourseware" | |
| ocw = "MIT OpenCourseWare" |
| "model": "learning_resources.LearningResourceOfferor", | ||
| "fields": { | ||
| "name": "OCW", | ||
| "name": "MIT OpenCourseware", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "MIT OpenCourseware", | |
| "name": "MIT OpenCourseWare", |
| "fields": { | ||
| "code": "ocw", | ||
| "name": "OCW", | ||
| "name": "MIT OpenCourseware", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "MIT OpenCourseware", | |
| "name": "MIT OpenCourseWare", |
learning_resources/constants.py
Outdated
| ocw = "OCW" | ||
| ocw = "MIT OpenCourseWare" | ||
| bootcamps = "Bootcamps" | ||
| xpro = "xPRO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to change this while we're here. I'll try to confirm.
| xpro = "xPRO" | |
| xpro = "MIT xPRO" |
Yeah, this must have been an oversight in the doc we were given. See https://openlearning.mit.edu/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. When you're able to confirm it update the issue and I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and I updated the issue. Sorry again for this oversight.
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
33cf325 to
a5c4e54
Compare
What are the relevant tickets?
https://github.com/mitodl/hq/issues/4748
Description (What does it do?)
This PR updates unit names in
offered_by.jsonandplatforms.jsonaccording to what is described in the attached issue.How can this be tested?
mit-openon this branchplatformsandoffered_bysections include the updated namesChecklist:
heroku run -a <app name> /bin/bash):./manage.py loaddata platforms offered_by./manage.py update_offered_by./manage.py update_platforms./manage.py backpopulate_resource_channels --overwrite./manage.py recreate_index --all