make primary buttons shadowy, remove edge=none #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| edge: { | ||
| options: ["circular", "rounded", "none"], | ||
| options: ["circular", "rounded"], |
Contributor
Author
There was a problem hiding this comment.
edge="none" is not in figma; it was added for resource cards, but that is handled a little differently now (changed in #1180 )
| hasBorder && { | ||
| backgroundColor: "transparent", | ||
| borderColor: "currentcolor", | ||
| borderStyle: variant === "secondary" ? "solid" : "none", |
Contributor
Author
There was a problem hiding this comment.
Previously, const hasBorder = variant === "secondary" || variant === "text". But that was weird because text variant doesn't actually have a border. It was just set that way to pick up backgroundColor: transparent.
Applying backgroundColor: transparent to the text variant separately is simpler / more understandable, imo.
| "Without Image": makeResource({ | ||
| "Without Image": { | ||
| ...makeResource(), | ||
| image: null, |
Contributor
Author
There was a problem hiding this comment.
This change is unrelated, but was something I did while opening
Decided to keep it.
ChristopherChudzicki
added
the
Needs Review
ChristopherChudzicki
force-pushed
the
cc/shadowy-buttons
branch
from
22adcae to
c917dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4700
Description (What does it do?)
Makes primary buttons (and only primary buttons) have a shadow to match figma.
Screenshots (if appropriate):
App There aren't too many primary buttons in the app so far.
Storybook:
How can this be tested?
yarn storybook) and check:Buttons should be unchanged, except primary buttons should have a shadow AND only in their default state (no shadow on hover).