resource type for learning materials #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
changed the title
ChristopherChudzicki
approved these changes
Jul 3, 2024
Contributor
ChristopherChudzicki
left a comment
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
👍 Nice. I left one comment, though we've had the "Clear all" resets tab behavior for at least a few weeks, so it doesn't necessarily need to change here.
|
|
||
| const facetNames = [ | ||
| "resource_type", | ||
| "resource_category", |
Contributor
There was a problem hiding this comment.
I don't think resource_category should be a facetName, btw.
- if it is, then "Clear All" will reset the tab
I discussed this once with Steve and we decided "Clear all" should not clear the tab, since it's associated with the left-hand facets / filters.
If you change, resource_category would needed to be added o the aggregation separately.
ChristopherChudzicki
approved these changes
Jul 3, 2024
abeglova
force-pushed
the
ab/resource_type_for_learning_materials
branch
from
dcbf54d to
6c70368
Compare
abeglova
force-pushed
the
ab/resource_type_for_learning_materials
branch
from
6c70368 to
df36f7f
Compare
mbertrand
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/4736
Description (What does it do?)
The "Resource Type" facet is displayed, but only if the selected tab is "Learning Material"
Screenshots (if appropriate):
How can this be tested?
Go to http://localhost:8062/search. There should not be a Resource Type facet displayed.
Click on the "Learning Materials" tab. There should not be a Resource Type facet displayed and you should be able to select a type of learning material
Go to http://localhost:8062/c/topic/mathematics
Again there should be a Resource Type facet only if Learning Material is selected