Unit and detail page copy updates #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
added
Needs Review
ChristopherChudzicki
requested changes
Jul 9, 2024
Contributor
ChristopherChudzicki
left a comment
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
Noticed a few minor things.
frontends/mit-open/src/page-components/ChannelDetails/ChannelDetails.tsx
Outdated
Show resolved
Hide resolved
frontends/mit-open/src/pages/UnitsListingPage/UnitsListingPage.tsx
Outdated
Show resolved
Hide resolved
frontends/mit-open/src/pages/UnitsListingPage/UnitsListingPage.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com>
….tsx Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com>
frontends/mit-open/src/page-components/ChannelDetails/ChannelDetails.tsx
Show resolved
Hide resolved
…etails.tsx Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com>
ChristopherChudzicki
approved these changes
Jul 9, 2024
mbertrand
pushed a commit
that referenced
this pull request
Jul 15, 2024
* fixing capitalization on channel detail panel * fixing link target * capitalizing academic * copy updates * adding data migration for copy updates * adding guard condition * changing rel type on external link * Update frontends/mit-open/src/pages/UnitsListingPage/UnitsListingPage.tsx Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com> * Update frontends/mit-open/src/pages/UnitsListingPage/UnitsListingPage.tsx Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com> * fixing fixture * Update frontends/mit-open/src/page-components/ChannelDetails/ChannelDetails.tsx Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com> * disabling lint check --------- Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4815
Description (What does it do?)
This PR makes makes copy changes from the "units" tab in this spreadsheet. Also make sure to reference notes in the ticket.
How can this be tested?
RUN_DATA_MIGRATIONS=true python manage.py migrateChecklist: