Skip to content

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Jul 9, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/4782

Description (What does it do?)

This Pr fixes mobile display and updates the ocw logo in the learning resource drawer.

Screenshots (if appropriate):

Screenshot 2024-07-09 at 2 16 19 PM Screenshot 2024-07-09 at 2 19 20 PM

How can this be tested?

  1. Checkout this branch.
  2. go to any page that lists learning resources and click on one to bring up the details panel.
  3. view the panel in mobile and try different content types to see how it looks

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Jul 9, 2024
@shanbady shanbady marked this pull request as ready for review July 9, 2024 18:28
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ChristopherChudzicki ChristopherChudzicki added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Jul 9, 2024
@shanbady shanbady merged commit 92e4111 into main Jul 9, 2024
@shanbady shanbady deleted the shanbady/resource-drawer-ui-issues branch July 9, 2024 20:19
@odlbot odlbot mentioned this pull request Jul 10, 2024
27 tasks
mbertrand pushed a commit that referenced this pull request Jul 15, 2024
* setting auto width for small sizes

* updating ocw logo

* updating ocw to new logo and fixing mobile display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants