Skip to content

Update eslint-config and friends #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2024
Merged

Update eslint-config and friends #1246

merged 2 commits into from
Jul 12, 2024

Conversation

@ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Jul 10, 2024 •
edited
Loading

What are the relevant tickets?

Opened this to check

Description (What does it do?)

Updates our eslint-config and some of its peer dependencies.

How can this be tested?

  1. Reinstall yarn dependencies (docker compose restart watch or yarn install) and run yarn lint-check. It should pass.
  2. You could also try triggering an error.

Notes

⚠️ This is using a git-installed version of eslint-config-mitodl. After that version is published, this PR should be updated.

@ChristopherChudzicki ChristopherChudzicki mentioned this pull request Jul 10, 2024
Merged
@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review July 10, 2024 16:52
@ChristopherChudzicki ChristopherChudzicki changed the title update-eslint-and-friends Update eslint-config and friends Jul 10, 2024
@abeglova abeglova self-assigned this Jul 11, 2024
abeglova
abeglova approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChristopherChudzicki ChristopherChudzicki merged commit 4c3f76d into main Jul 12, 2024
@odlbot odlbot mentioned this pull request Jul 12, 2024
Merged
4 tasks
@rhysyngsun rhysyngsun deleted the cc/update-eslint-and-friends branch February 7, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abeglova abeglova abeglova approved these changes

Assignees

@abeglova abeglova

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristopherChudzicki @abeglova