Make static/hash.txt served again #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysyngsun
force-pushed
the
nl/fix-hash-txt
branch
from
371422e to
91ae587
Compare
shanbady
approved these changes
Jul 12, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
Appears to work. one thing to note is that the static directory "static" was not created when checking out this branch ( had to manually create it)
shanbady
added
Waiting on author
and removed
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
This is a follow up to #1179, which removed the serving of the frontend via nginx - the side effect of this is
hash.txtwas no longer being served so our release-script bot can't detect when deployments happen anymoreHow do I test it?
Run
echo "abc" > static/hash.txtand thendocker compose up. You should then be able to see this dummy file at http://api.open.odl.local:8063/static/hash.txt