-
Notifications
You must be signed in to change notification settings - Fork 3
Subscription email template updates #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
mbertrand
pushed a commit
that referenced
this pull request
Aug 6, 2024
* adding resource type * conditionalizing subject line * limiting list of resources to 5 * adding images to email * fixing f-string * template style fixes * fixing logo * formatting changes and adding footer * adding url context to email templates and some style changes * adding test * fixing button float and adding background * cloning model method utilities * inferring channel urls for groups * initial changes to send individual emails * fixing view more url and checking for null in resource.image * fixing subject line * fixing footer urls * capping at 10 items * fixing saved search label * fixing saved search type * fix spacing * fixing tests * adding short subject in template and some style fixes * fixing method * updating dashboard settings url to match upcoming changes in pr #1348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4890
Description (What does it do?)
This Pr updates the subscription email template according to https://github.com/mitodl/hq/issues/4890 figma
How can this be tested?
docker compose restart celeryAdditional Context
The email you receive during testing will have a broken logo image which is expected this gets deployed to a live environment.



Additionally, the links to unsubscribe and manage preferences will route to a currently non-existent page which is also expected until #1331 lands