Skip to content

Conversation

@gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Aug 22, 2024

What are the relevant tickets?

Follow-up to #1454

Description (What does it do?)

This PR fixes something that was missed in the mobile implementation in the above PR, setting the proper width of the adornment buttons.

Screenshots (if appropriate):

image

How can this be tested?

  • Spin up mit-learn on this branch
  • Visit the home page
  • Use the mobile inspector to ensure that the adornment buttons are the proper width

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label Aug 22, 2024
@gumaerc gumaerc changed the title search box adornment buttons should be 56px wide on mobile 1454 follow-up: fix mobile adornment button width Aug 22, 2024
@shanbady shanbady self-assigned this Aug 22, 2024
@shanbady shanbady self-requested a review August 22, 2024 17:50
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shanbady shanbady added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Aug 22, 2024
@gumaerc gumaerc merged commit 192ad23 into main Aug 22, 2024
@odlbot odlbot mentioned this pull request Aug 22, 2024
4 tasks
@rhysyngsun rhysyngsun deleted the cg/homepage-hero-updates-hotfix branch February 7, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants