Cache unit page counts #1507
Merged
Cache unit page counts #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
added
Needs Review
mbertrand
reviewed
Sep 5, 2024
Member
mbertrand
left a comment
mbertrand
left a comment
There was a problem hiding this comment.
Looks great, only question is regarding this:
which get invalidated when new resources are fetched
I'm not seeing that, if I add new OCW courses, the OCW count remains the same. Should the cache get invalidated when courses are added?
mbertrand
approved these changes
Sep 5, 2024
Member
mbertrand
left a comment
mbertrand
left a comment
There was a problem hiding this comment.
Cache is invalidated now after adding more courses, 👍
|
|
||
|
|
||
| class ChannelCountsSerializer(serializers.ModelSerializer): | ||
| counts = serializers.SerializerMethodField(read_only=True) |
mbertrand
added
Waiting on author
and removed
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5246
Description (What does it do?)
Currently the "programs" and "courses counts displayed on the unit page(/units/) comes from opensearch aggregations which has been determined to be expensive for just getting counts of things that change infrequently. This PR moves the counts off to their own endpoint which is then cached and invalidated along with learning resources (which get invalidated when new resources are fetched).
How can this be tested?