Skip to content

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Sep 5, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5256

Description (What does it do?)

This PR sorts the date dropdown and ensures that the closest upcoming date is pre-selected in the learning resource expanded drawer

Screenshots (if appropriate):

Screenshot 2024-09-05 at 2 10 16 PM Screenshot 2024-09-05 at 2 10 31 PM

How can this be tested?

  1. checkout this branch. make sure you have data/learning resources loaded (in particular ones with multiple runs/dates)
  2. find a resource with multiple upcoming runs and open the resource drawer
  3. see that the dates are chronologically sorted and that the next upcoming date is preselected

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Sep 5, 2024
@shanbady shanbady marked this pull request as ready for review September 5, 2024 18:14
@abeglova abeglova self-assigned this Sep 5, 2024
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shanbady shanbady merged commit de21330 into main Sep 5, 2024
This was referenced Sep 6, 2024
@shanbady shanbady deleted the shanbady/fix-course-panel-start-date branch September 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants