-
Notifications
You must be signed in to change notification settings - Fork 3
Dockerfile for the Next.js frontend and Action to build and publish #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f43fbb to
f6c4d89
Compare
75c979f to
1341b46
Compare
6d0fbfb to
e8d66d5
Compare
a22f772 to
7a7bb78
Compare
feoh
approved these changes
Sep 16, 2024
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 18, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
ChristopherChudzicki
pushed a commit
that referenced
this pull request
Sep 19, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 23, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 23, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
jonkafton
added a commit
that referenced
this pull request
Sep 24, 2024
…1542) * Dockerfile for the Next.js service * Build/publish job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Docker container for https://github.com/mitodl/hq/issues/5396
Build and publish for https://github.com/mitodl/hq/issues/5400
In preparation for https://github.com/mitodl/hq/issues/5399
Description (What does it do?)
How can this be tested?
Image can build locally with:
And runs with:
For deployment we just need to pass the
PORTon the environment. The other env vars are public and provided at build time.Currently using these values for RC (secrets from GitHub Actions):
Assumes that DNS will point to
next.rc.learn.mit.edufor the RC deployment.