[NextJS] fix initial carousel position #1546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
cc/nextjs-carousel
branch
from
fcd8e02 to
49b951f
Compare
ChristopherChudzicki
added
the
Needs Review
| * on the `.slick-track` element. This, combined with auto margoins, | ||
| * causes the carousel to render with strange positioning initially. | ||
| */ | ||
| width: "unset !important", |
Contributor
Author
There was a problem hiding this comment.
This carousel issue is the only instance I've come across so far where something has behaved unexpectedly different on server and client.
ChristopherChudzicki
changed the title
ChristopherChudzicki
added a commit
that referenced
this pull request
Sep 13, 2024
ChristopherChudzicki
added a commit
that referenced
this pull request
Sep 16, 2024
jonkafton
pushed a commit
that referenced
this pull request
Sep 18, 2024
ChristopherChudzicki
added a commit
that referenced
this pull request
Sep 19, 2024
jonkafton
pushed a commit
that referenced
this pull request
Sep 23, 2024
jonkafton
pushed a commit
that referenced
this pull request
Sep 23, 2024
jonkafton
pushed a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5415
Description (What does it do?)
Fixes carousel initial render
Screenshots (if appropriate):
With JS disabled:
and enabled:
How can this be tested?
Visit homepage. Carousel should not shift position as homepage loads.
You can also see this affect by disabling javascript: