always use dfs_query_then_fetch #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
approved these changes
Sep 13, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
A program showed up on the 4th page for me but I assume thats due to the difference in the data loaded on my local.
shanbady
added
Waiting on author
and removed
Needs Review
abeglova
force-pushed
the
ab/always-use_dfs_query_then_fetch
branch
from
2f75e00 to
d72e7cf
Compare
This was referenced Sep 17, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/5351
Description (What does it do?)
Programs are consistently not shown in search results with a text search because scores are calculated separately on each index and not consistent between indexes. Setting search_type="dfs_query_then_fetch' fixes the issue. In #1518 i added a search parameter to use that search type because I was worried that we would get worse search performance. I tested search on rc and search_type="dfs_query_then_fetch' does not seem to affect performance, so we can just use it for all searches.
How can this be tested?
verify that search works as expected
verify that http://open.odl.local:8062/search/?q=Machine+Learning returns a program on the first or second page