Skip to content

Conversation

@gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Sep 16, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5359

Description (What does it do?)

This PR simply changes the style on the wrappers of items in the "Browse by Topic" section of the homepage to use align-items: center instead of align-items: start, centering the icons vertically next to the text as desired.

Screenshots (if appropriate):

image
image

How can this be tested?

  • Spin up mit-learn on this branch
  • Visit the home page at http://localhost:8062/
  • Verify that the Browse by Topic sections renders as expected

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label Sep 16, 2024
Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns as expected!

@jonkafton jonkafton removed the Needs Review An open Pull Request that is ready for review label Sep 17, 2024
@gumaerc gumaerc merged commit 63aca88 into main Sep 17, 2024
@rhysyngsun rhysyngsun deleted the cg/fix-homepage-browse-by-topic-icon-alignment branch February 7, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants