CI to push to Heroku #1569
Merged
CI to push to Heroku #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feoh
approved these changes
Sep 16, 2024
jonkafton
force-pushed
the
nextjs
branch
9 times, most recently
from
070e230 to
98d37de
Compare
ChristopherChudzicki
force-pushed
the
nextjs
branch
from
98d37de to
9bab4f4
Compare
jonkafton
force-pushed
the
jk/5396-ci-deploy-to-heroku
branch
from
248fff9 to
30e9770
Compare
jonkafton
added a commit
that referenced
this pull request
Sep 23, 2024
* Use action with more options for context and Dockerfile location * Escape newline * Deploy to Heroku tests * Missing checkouts * Heroku login test * Build directly with Heroku CLI * Rename to web (Heroku process type) * Release web * Debug build args * Debug build var * Comma separated build args * Remove multiline spaces * Clean up env vars * Deploy only on the nextjs branch
jonkafton
added a commit
that referenced
this pull request
Sep 23, 2024
* Use action with more options for context and Dockerfile location * Escape newline * Deploy to Heroku tests * Missing checkouts * Heroku login test * Build directly with Heroku CLI * Rename to web (Heroku process type) * Release web * Debug build args * Debug build var * Comma separated build args * Remove multiline spaces * Clean up env vars * Deploy only on the nextjs branch
jonkafton
added a commit
that referenced
this pull request
Sep 24, 2024
* Use action with more options for context and Dockerfile location * Escape newline * Deploy to Heroku tests * Missing checkouts * Heroku login test * Build directly with Heroku CLI * Rename to web (Heroku process type) * Release web * Debug build args * Debug build var * Comma separated build args * Remove multiline spaces * Clean up env vars * Deploy only on the nextjs branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
CI job to deploy for https://github.com/mitodl/hq/issues/5400
Description (What does it do?)
We've decided to use Heroku's registry instead of Dockerhub to push and then deploy the Docker image.
Using https://github.com/marketplace/actions/deploy-to-heroku#deploy-with-docker
This deploys to the Next.js RC environment on all pushes while we test, though we'll want to move this to a workflow on the
nextjsbranch only.