Skip to content

Conversation

@ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

followup to #1568

Description (What does it do?)

fixes a color issue on the attestant title

Screenshots (if appropriate):

Now (and release):

Screenshot 2024-09-18 at 12 37 27 PM

Before (main)
Screenshot 2024-09-18 at 12 27 02 PM

How can this be tested?

  1. Check testimonials on homepage AND unit pages. Homepage should be dark text on white background, unit pages should be light text on dark background

{attestation?.attestant_name}
</AttestantName>
<AttestantTitle variant={variant}>
<AttestantTitle variant={variant} color={color}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inside the AttestantBlock component, to which we recently added a color prop. AttestantTitle should receive the same color.

@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review September 18, 2024 16:39
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopherChudzicki ChristopherChudzicki merged commit 486764a into main Sep 18, 2024
@odlbot odlbot mentioned this pull request Sep 18, 2024
15 tasks
@rhysyngsun rhysyngsun deleted the cc/testimonial-color-fix branch February 7, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants