Skip to content

Conversation

@ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Sep 20, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5565

Description (What does it do?)

This PR makes the <meta name="robots" content="noindex"> the default. I.e., indexing is opt-in instead of opt-out. This is the same as what we currently do on main. Note that currently all releases of Learn should have noindex, per our "soft launch" status.

How can this be tested?

  1. With MITOL_NOINDEX undefined, check that you do get a noindex tag.
  2. With MITOL_NOINDEX=false, check that you do not get a noindex tag.

@ChristopherChudzicki ChristopherChudzicki changed the base branch from main to nextjs September 20, 2024 20:19
@ChristopherChudzicki ChristopherChudzicki changed the title Cc/nextjs change noindex default [NextJS] Make noindex tag opt-out (like main) rather than opt-in Sep 20, 2024
@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Sep 20, 2024
@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review September 20, 2024 20:26
@jonkafton jonkafton self-assigned this Sep 23, 2024
@jonkafton jonkafton force-pushed the cc/nextjs-change-noindex-default branch from 8d46bee to a201e85 Compare September 23, 2024 14:28
@jonkafton jonkafton merged commit a7041ef into nextjs Sep 23, 2024
Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonkafton jonkafton removed their assignment Sep 23, 2024
@jonkafton jonkafton removed the Needs Review An open Pull Request that is ready for review label Sep 23, 2024
Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jonkafton added a commit that referenced this pull request Sep 23, 2024
* align default robots tag w main

* Apply robots meta to all pages

---------

Co-authored-by: Jon Kafton <939376+jonkafton@users.noreply.github.com>
jonkafton added a commit that referenced this pull request Sep 23, 2024
* align default robots tag w main

* Apply robots meta to all pages

---------

Co-authored-by: Jon Kafton <939376+jonkafton@users.noreply.github.com>
jonkafton added a commit that referenced this pull request Sep 24, 2024
* align default robots tag w main

* Apply robots meta to all pages

---------

Co-authored-by: Jon Kafton <939376+jonkafton@users.noreply.github.com>
@odlbot odlbot mentioned this pull request Oct 22, 2024
74 tasks
@rhysyngsun rhysyngsun deleted the cc/nextjs-change-noindex-default branch February 7, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants