Add task_reject_on_worker_lost=True to finish_recreate_index, use return instead of raise for replaced tasks #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbertrand
force-pushed
the
mb/task_retry_sysexit
branch
from
fa3daaa to
c51cb9a
Compare
…urn instead of raise for replaced tasks
mbertrand
force-pushed
the
mb/task_retry_sysexit
branch
from
c51cb9a to
54668c5
Compare
mbertrand
added a commit
that referenced
this pull request
Oct 4, 2024
…urn instead of raise for replaced tasks (#1608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5615
Description (What does it do?)
reject_on_worker_lost=Trueto finish_recreate_index taskreturninstead ofraiseon replaced tasksHow can this be tested?
Run
./manage.py recreate_index --alllocally, it should still work.Otherwise, probably best tested on RC by starting a reindex there and then restarting the worker dynos.