Skip to content

Conversation

@jonkafton
Copy link
Contributor

@jonkafton jonkafton commented Sep 26, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5412
Closes https://github.com/mitodl/hq/issues/5413

Description (What does it do?)

Migrates remaining images to Next.js

  • <img /> tags replaced by Next.js <Image />
  • Dimensions specified for Logo component (dynamic width or height and hardcoded aspect per image)
  • Background images are imported as modules

Also fixes the MIT logo in the header not linking to the homepage.

How can this be tested?

Images should render correctly. These have been modified:

  • Platform logos in the learning resource drawer
  • Dashboard background
  • The Dome image on the /about page
  • Attester thumbnail in testimonials (homepage)
  • Program letter page images

The MIT logo in the header navigates to the homepage.

@jonkafton jonkafton changed the base branch from main to nextjs September 26, 2024 19:40
@jonkafton jonkafton marked this pull request as draft September 26, 2024 19:41
@jonkafton jonkafton marked this pull request as ready for review September 27, 2024 13:48
@jonkafton jonkafton added the Needs Review An open Pull Request that is ready for review label Sep 27, 2024
@abeglova abeglova self-assigned this Sep 30, 2024
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonkafton jonkafton merged commit 682d111 into nextjs Sep 30, 2024
@odlbot odlbot mentioned this pull request Oct 22, 2024
74 tasks
@rhysyngsun rhysyngsun deleted the jk/5412-repo-images branch February 7, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants