Skip to content

Positioning for search utils input close button #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Positioning for search utils input close button #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
961f983
Positioning for search utils input close button
jonkafton Sep 27, 2024
da748a0
Lint
jonkafton Sep 30, 2024
9f809b7
Prefix _ for lint rule
jonkafton Sep 30, 2024
347b30e
Merge branch 'nextjs' into jk/5472-embedded-icons
jonkafton Oct 8, 2024
469bc76
Merge branch 'nextjs' into jk/5472-embedded-icons
jonkafton Oct 9, 2024
7c453fa
Install published course-search-utils
jonkafton Oct 9, 2024
3f1ea9d
Merge branch 'nextjs' into jk/5472-embedded-icons
jonkafton Oct 10, 2024
aa6eeda
Center facet section headers and improve close button positioning
jonkafton Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions frontends/main/src/page-components/SearchDisplay/SearchDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ const FacetStyles = styled.div`

i {
color: ${({ theme }) => theme.custom.colors.silverGrayLight};

svg {
display: block;
}
}

&:hover i {
Expand Down Expand Up @@ -222,6 +226,7 @@ const FacetStyles = styled.div`

.input-wrapper {
position: relative;
margin-bottom: 10px;

.input-postfix-icon {
display: none;
Expand All @@ -230,12 +235,25 @@ const FacetStyles = styled.div`
.input-postfix-button {
cursor: pointer;
position: absolute;
right: 5px;
top: 50%;
transform: translateY(-50%);
border: none;
background: none;
padding: 0;
width: 20px;
height: 20px;
right: 7px;

svg {
color: ${({ theme }) => theme.custom.colors.silverGrayLight};
width: 100%;
height: 100%;
display: block;

:hover {
color: ${({ theme }) => theme.custom.colors.darkGray2};
}
}

span {
color: ${({ theme }) => theme.palette.text.secondary};
Expand All @@ -246,9 +264,9 @@ const FacetStyles = styled.div`

input.facet-filter {
background-color: initial;
padding: 10px;
padding: 10px 26px 10px 10px;
margin-top: 0;
margin-bottom: 10px;
margin-bottom: 0;
width: 100%;
}

Expand Down
2 changes: 1 addition & 1 deletion frontends/ol-components/src/components/Alert/Alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { theme } from "../ThemeProvider/ThemeProvider"
import type { AlertProps as MuiAlertProps } from "@mui/material/Alert"

type Colors = {
[Severity in AlertColor]: string
[_Severity in AlertColor]: string
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, what was this for?

Same question below for _key

Copy link
Contributor Author

@jonkafton jonkafton Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If was seeing an eslint error on the mapped type - a bug perhaps:

'Severity' is defined but never used. Allowed unused vars must match /^_/u.eslint[@typescript-eslint/no-unused-vars](https://typescript-eslint.io/rules/no-unused-vars)

}

const COLORS: Colors = {
Expand Down
2 changes: 1 addition & 1 deletion frontends/ol-components/src/components/Input/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ const baseInputStyles = (theme: Theme) => ({
type CustomInputProps = { responsive?: true }
const noForward = Object.keys({
responsive: true,
} satisfies { [key in keyof CustomInputProps]: boolean })
} satisfies { [_key in keyof CustomInputProps]: boolean })

const Input = styled(InputBase, {
shouldForwardProp: (prop) => !noForward.includes(prop),
Expand Down
Loading
Loading