"unfollow" confirmation modal and "Unfollow All" button #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
added
Needs Review
|
@shanbady looking at the screenshots, I'm noticing an additional question mark that's not needed in the "Unfollow All" modal. |
Contributor
Author
Fixed |
gumaerc
approved these changes
Oct 2, 2024
Contributor
gumaerc
left a comment
gumaerc
left a comment
There was a problem hiding this comment.
👍 LGTM
However, I noticed that the title of the PR is "Follow/Unfollow All" but there is no "Follow All" function. We should change the title to be more accurate, in case someone looks at this in the future.
shanbady
changed the title
mbertrand
pushed a commit
that referenced
this pull request
Oct 4, 2024
* adding initial button * adding working dialog * fixing typecheck lint * fixing styles and checking for existing subscriptions * adding tests * fixing lint * adding another test. fixing dialog header * fixing lint * remove trailing question mark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5636
Description (What does it do?)
This PR adds the following to the settings page in the user dashboard:
Screenshots (if appropriate):
How can this be tested?