fix Safari MIT logo bug #1631
Merged
fix Safari MIT logo bug #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumaerc
changed the title
shanbady
requested changes
Oct 1, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
There are a few issues I am seeing. One that only happens in safari if you visit the units page:
The other issue (less severe) is that the text in the header scrunches at a certain size
The other thing I just noticed is that it appears the header doesn't reflect logged in state (seeing this in safari only). I logged in via django admin and go back to the home page and I am not shown as logged in
shanbady
approved these changes
Oct 1, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
Approving to get header changes out. will create tickets for other items noticed.
shanbady
added
Waiting on author
and removed
Needs Review
mbertrand
pushed a commit
that referenced
this pull request
Oct 4, 2024
* apply StyledMITLogoLink styles directly to img element * fix app container padding based on header height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Follow-up to #1622
Description (What does it do?)
This PR fixes a bug with Safari where the MIT logo in the header was not being scaled properly due to the width / height only being applied to the parent and not directly to the
imgelementScreenshots (if appropriate):
How can this be tested?
mit-learnon this branch