fix units page cards in Safari #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbertrand
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5684
Description (What does it do?)
This PR fixes an issue with the height of the cards on the units listing page. MUI Cards by default have a
height: 100%rule on them. This conflicts with theflex-grow: 1setting used by the cards on the units page. Since the cards have dynamic content that can be edited, two cards with different implicit heights could end up next to each other. Theflex-growrule ensures that the shorter card grows to match the height of the tallest card, and the course / program counts stay pinned to the bottom of the card.How can this be tested?
mit-learn