Skip to content

Conversation

@mbertrand
Copy link
Member

What are the relevant tickets?

Related to https://github.com/mitodl/hq/issues/5615

Description (What does it do?)

Tries to avoid the following error which occurred on RC when restarting the celery dyno:

2024-10-01T18:11:19.451534+00:00 app[extra_worker_performance.1]: [2024-10-01 18:11:19,446: ERROR/ForkPoolWorker-144] Task learning_resources_search.tasks.index_learning_resources[f5205655-dcae-4cff-9317-51621c9ee3df] raised unexpected: EncodeError(TypeError('Object of type SystemExit is not JSON serializable'))

How can this be tested?

Follow the same instructions as the previous PR: #1615

Additional Context

@mbertrand mbertrand added the Needs Review An open Pull Request that is ready for review label Oct 1, 2024
@shanbady shanbady self-assigned this Oct 1, 2024
@shanbady shanbady self-requested a review October 1, 2024 19:15
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks could. seems to work from my testing but I did notice that we dont have deindex_contentfiles handling acks_late, reject_on_worker_lost or catching the SystemExit. do we need to handle this same way?

@mbertrand
Copy link
Member Author

looks could. seems to work from my testing but I did notice that we dont have deindex_contentfiles handling acks_late, reject_on_worker_lost or catching the SystemExit. do we need to handle this same way?

Maybe - deindex_contentfiles isn't run during a recreate_index task. But if this finally works, then it might be good to handle more tasks the same way.

@mbertrand mbertrand merged commit c7d10e8 into main Oct 2, 2024
10 checks passed
@odlbot odlbot mentioned this pull request Oct 2, 2024
3 tasks
mbertrand added a commit that referenced this pull request Oct 4, 2024
@mbertrand mbertrand deleted the mb/sys_exit_3 branch October 23, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants