updating email template with new logo #1638
Conversation
shanbady
added
Work in Progress
Needs Review
mbertrand
left a comment
mbertrand
left a comment
There was a problem hiding this comment.
Not directly related to this PR, but I noticed the unsubscribe link is missing a "/", I think this might be because I have MITOPEN_APP_BASE_URL=http://open.odl.local:8062 (no ending slash). Neither does the same setting on RC or prod. Otherwise looks great.
| "career advancement, and organizations seeking to meet modern-day " | ||
| "challenges by expanding the knowledge and skills of their employees. " | ||
| "Courses are delivered in a range of formats—in-person (on-campus " | ||
| "and live online), online, and through hybrid approaches—to " |
There was a problem hiding this comment.
Is this right? approaches—to? Not approaches to?
There was a problem hiding this comment.
Yea - not easily visible on github but its a long dash approaches—to https://rc.learn.mit.edu/c/unit/mitpe/
| "career advancement, and organizations seeking to meet modern-day " | ||
| "challenges by expanding the knowledge and skills of their employees. " | ||
| "Courses are delivered in a range of formats—in-person (on-campus " | ||
| "and live online), online, and through hybrid approaches—to " |
mbertrand
added
Waiting on author
and removed
Needs Review
good catch! pushed the fix |
shanbady
deleted the
shanbady/logo-updates-to-subscription-email-templates
branch
* updating email template with new logo * adding copy update for unit * adding trailing slash * adding trailing slash
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5674
Description (What does it do?)
Updates the logo in the header of subscription emails
Note: unrelated to the emails - this PR also contains a data migration to include a small copy change to one of the units
Screenshots (if appropriate):
How can this be tested?
Follow instructions on this PR to send yourself a subscription email and validate how it looks