reset search page in SearchField #1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
cc/search-page-reset
branch
from
5a0780c to
1cf65b6
Compare
Comment on lines
+30
to
+32
| if (POSTHOG?.api_key) { | ||
| posthog.capture("search_update", { isEnter: isEnter }) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I moved the posthog stuff out of ol-components and into the new SearchField component. Since ol-components is generally styling / UI focused, I think this new component is a better place for the posthog call.
ChristopherChudzicki
force-pushed
the
cc/search-page-reset
branch
from
1cf65b6 to
6c94439
Compare
ChristopherChudzicki
added
the
Needs Review
mbertrand
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5697
Description (What does it do?)
This adds a
SearchFieldcomponent wrappingSearchInputthat handles some of the application logic, like resetting search page to 1.How can this be tested?