Skip to content

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Oct 7, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5564

Description (What does it do?)

This PR updates the /topics and /departments channel pages to use the new cached counts api endpoints to fetch program and course counts.

How can this be tested?

  1. visit the production MIT Learn topics and departments channel pages with web inspector open. note that the page makes multiple requests to fetch counts to the search endpoint (looks something like /api/v1/learning_resources_search/?aggregations=department&resource_type=course)
  2. checkout this branch. make sure you have topics and departments loaded up locally.
  3. visit the topics and departments channel pages and note that the requests to the search endpoint do not show up. Also verify the counts for programs and courses look accurate. note: the counts endpoint is cached so it wont update immediately after deleting something - you will need to clear the cache manually to see it update

@shanbady shanbady added Work in Progress Needs Review An open Pull Request that is ready for review and removed Work in Progress labels Oct 7, 2024
@shanbady shanbady marked this pull request as ready for review October 7, 2024 20:27
@abeglova abeglova self-assigned this Oct 8, 2024
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanbady shanbady merged commit b78f678 into main Oct 8, 2024
11 checks passed
@shanbady shanbady deleted the shanbady/department-topic-page-counts branch October 8, 2024 15:30
@odlbot odlbot mentioned this pull request Oct 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants