Shanbady/next w main #1662
Merged
Shanbady/next w main #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removing backend randomization * removing results randomization * moiving shuffle to frontend * fixing tests * test fix * refactoring to old randomization method on frontend * updating spec * fixing typechecks * updating spec and adding position field to api * adding position to factory * fixing test
ChristopherChudzicki
approved these changes
Oct 8, 2024
Contributor
ChristopherChudzicki
left a comment
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
👍
Suggestion: I think we should delete the old MetaTags, then we'd get a conflict if this situation arose again.
Contributor
Author
|
creating a separate PR to remove/cleanup the old metatag functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main (d9ed99a) into nextjs branch