Skip to content

Conversation

@gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Oct 11, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5745

Description (What does it do?)

This PR addresses some spacing issues between the main and nextjs branches:

  • #app-container styles moved to PageWrapper
  • fixed padding on the home page hero image
  • fixed search input padding issue

Screenshots (if appropriate):

image
image

How can this be tested?

  • Spin up this branch of mit-learn (If you are coming from main you will need to rebuild your containers)
  • Visit the home page at http://localhost:8062/
  • Verify that the styles described above and in the issue match production (https://learn.mit.edu)

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label Oct 11, 2024
@shanbady shanbady self-assigned this Oct 11, 2024
@shanbady shanbady self-requested a review October 11, 2024 15:45
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍

@shanbady shanbady added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Oct 11, 2024
@gumaerc gumaerc merged commit e5deffa into nextjs Oct 11, 2024
12 checks passed
@odlbot odlbot mentioned this pull request Oct 22, 2024
74 tasks
@rhysyngsun rhysyngsun deleted the cg/nextjs-fix-container-padding branch February 7, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants