Make add to list dialog scrollable #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const resourceQuery = useLearningResourcesDetail(resourceId) | ||
| const resource = resourceQuery.data | ||
| const listsQuery = useLearningPathsList() | ||
| const listsQuery = useLearningPathsList({ limit: LIST_LIMIT }) |
Contributor
Author
There was a problem hiding this comment.
Showing up to 100 and scrolling isn't a great solution. We should have infinite scroll or something.
This is a remediation to unblock the DLLs.
|
|
||
| const Content = styled.div` | ||
| margin: 28px 28px 40px; | ||
| margin: 28px; |
Contributor
Author
There was a problem hiding this comment.
Previously, in Figma, a couple dialogs had 40px between the content and the dialog footer but most had 28px.
In THE CODE it was determined via Dialog vs FormDialog. Both used 40px margin on the content, but FormDialog also had -12px on the footer for an effective 28px. This is (a) weird, and (b) the negative margin approach did not work well with scrolling overflow. (Which is why it's showing up in this PR).
Confirmed with @steven-hatch we want 28px uniformly across the dialogs.
Here's an example of a noticeable change:
Closed
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5774
Description (What does it do?)
Screenshots (if appropriate):
Change: The AddToListDialog shows more lists and is scrollable (if necessary):
Unchanged: Most other dialogs
How can this be tested?