Shanbady/xpro logo for all xpro offerings #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumaerc
approved these changes
Oct 16, 2024
Contributor
gumaerc
left a comment
gumaerc
left a comment
There was a problem hiding this comment.
👍 LGTM
Just noticed a small typo in your test's docstring:
| ) | ||
|
|
||
| test.each([ResourceTypeEnum.PodcastEpisode])( | ||
| "Renders xpro logo onditionally on offered_by=xpro and not platform.code", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5802
Description (What does it do?)
This PR makes sure that for learning resource drawers if the offered_by is xpro we ignoring the platform.code and always show the "On "
How can this be tested?