Ab/search synonyms #1697
Merged
Ab/search synonyms #1697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
approved these changes
Oct 17, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
Functionality appears to work (tested in codespace with ai example). One non-blocking suggestion I have which might make this list easier to update (and potentially expand via some automated process in the future) is to move the synonyms to a text file and reference it via "synonyms_path".
shanbady
added
Waiting on author
and removed
Needs Review
Contributor
Author
|
I think while we have so few synonyms just keeping them in the code is easier. If we decide to expand the synonyms list substantially, we should do what you suggests and keep them in a text file. |
abeglova
force-pushed
the
ab/search-synonyms
branch
from
ebe37ea to
fb65cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/5781
Description (What does it do?)
This adds a list of synonyms to the search analyzer.
How can this be tested?
run ./manage.py recreate_index --all
Verify that
http://open.odl.local:8062/search?q=ai and http://open.odl.local:8062/search?q=artificial+intelligence have the same results