-
Notifications
You must be signed in to change notification settings - Fork 3
search facet accessibility fixes #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing this I'm seeing certain facets have the visibility set to hidden but not all of them. For example the topics and department filters still had .facet-visible elements with visibility:visible when hidden.
|
@shanbady Thanks, this should be ready for another look |
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5421
Closes https://github.com/mitodl/hq/issues/5429
Description (What does it do?)
This PR takes advantage of the
facet-transitioningclass added in mitodl/course-search-utils#146, allowing us to setvisibility: hiddenonfacet-visibleitems while they are not expanded or transitioning. The default color of the expand / collapse caret on facets was also changed tosilverGrayDarkin accordance with https://github.com/mitodl/hq/issues/5429.How can this be tested?
First, we will need to get a new version of
course-search-utilscourse-search-utilson thecg/add-facet-transitioning-classbranch: https://github.com/mitodl/course-search-utilsyarn installand thenyarn typescriptto generate the librarymit-learn, overwrite the contents of thenode_modules/@mitodl/course-search-utils/distfolder with the contents ofcourse-search-utils/distthat we just builtmit-learnon thecg/facet-accessibilitybranchfacet-visibleitems within the collapsed facet and ensure they have thevisibility: hiddenrule applied to themfacet-visibleitemsvisibility: hiddenrule is removedChecklist:
course-search-utilsinpackage.jsonwith the newly released version in this PR before merging it