Skip to content

Conversation

@shanbady
Copy link
Contributor

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5545

Description (What does it do?)

This PR changes the aria-label for the add to user list button to "Bookmark (resource type)"

How can this be tested?

  1. checkout this branch.
  2. validate that the aria label for the add to user list (little bookmark icon) on resource cards says "Bookmark (resource type)"
  • Screenshot 2024-10-16 at 1 35 48 PM
  1. optionally use a screen reader and verify it captures the aria-label

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Oct 16, 2024
@shanbady shanbady marked this pull request as ready for review October 16, 2024 17:38
Copy link
Contributor

@gumaerc gumaerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

The only thing I might suggest here, even though it's not part of the issue, is to do the same thing with the Add to Learning Path buttons. The language for the User List button is "Bookmark <resource_type>" so maybe for learning paths we could do "Add <resource_type> to Learning Path?"

@shanbady
Copy link
Contributor Author

👍 LGTM

The only thing I might suggest here, even though it's not part of the issue, is to do the same thing with the Add to Learning Path buttons. The language for the User List button is "Bookmark <resource_type>" so maybe for learning paths we could do "Add <resource_type> to Learning Path?"

tagging @sovsey for thoughts on this

@sovsey
Copy link

sovsey commented Oct 16, 2024

I don't think we need to include the "Add to Learning Path" button here for now. @ChristopherChudzicki please chime in if you think otherwise!

@shanbady shanbady merged commit 7ddee60 into main Oct 16, 2024
11 checks passed
@shanbady shanbady deleted the shanbady/improve-bookmark-button-label branch October 16, 2024 20:16
This was referenced Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants