Skip to content

Config to set cache control headers #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Config to set cache control headers #1700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4433224
Middleware to set cache headers
jonkafton Oct 16, 2024
2d3132e
Set headers in the config
jonkafton Oct 16, 2024
edafe98
Upgrade Next.js
jonkafton Oct 16, 2024
2757605
Regex to exclude paths with a file extension to apply only to routes
jonkafton Oct 16, 2024
8ebc4ea
Remove middleware file
jonkafton Oct 16, 2024
b23a32d
Instruct to only store in shared cache (not browsers)
jonkafton Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions frontends/main/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,46 @@ const nextConfig = {
]
},

async headers() {
return [
/* This is intended to target the base HTML responses. Some are dynamically rendered,
* so Next.js instructs no-cache, however we are currently serving public content that
* is cacheable. Excludes everything with a file extension so we're matching only on routes.
*/
Comment on lines +62 to +65
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is mention RSC here, too.

Suggested change
/* This is intended to target the base HTML responses. Some are dynamically rendered,
* so Next.js instructs no-cache, however we are currently serving public content that
* is cacheable. Excludes everything with a file extension so we're matching only on routes.
*/
/* This is intended to target the base HTML responses and streamed RSC
* content. Some routes are dynamically rendered, so NextJS by default
* sets no-cache. However we are currently serving public content that is
* cacheable.
*
* Excludes everything with a file extension so we're matching only on routes.
*/

{
source: "/((?!.*\\.[a-zA-Z0-9]{2,4}$).*)",
headers: [
{
key: "Cache-Control",
value: "s-maxage=120",
},
],
},

/* Images rendered with the Next.js Image component have the cache header
* set on them, but CSS background images do not.
*/
{
source: "/images/(.*)",
headers: [
{
key: "Cache-Control",
value: "s-maxage=600",
},
],
},
{
source: "/favicon.ico",
headers: [
{
key: "Cache-Control",
value: "s-maxage=31536000",
},
],
},
]
},

images: {
remotePatterns: [
{
Expand Down
2 changes: 1 addition & 1 deletion frontends/main/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"api": "workspace:*",
"formik": "^2.4.6",
"lodash": "^4.17.21",
"next": "^14.2.7",
"next": "^14.2.15",
"ol-ckeditor": "0.0.0",
"ol-components": "0.0.0",
"ol-utilities": "0.0.0",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading