bundle analyzer, fix search page + channel page JS sizes #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
changed the title
ChristopherChudzicki
force-pushed
the
cc/analyze
branch
from
b470818 to
423eee0
Compare
ChristopherChudzicki
added
the
Needs Review
ChristopherChudzicki
force-pushed
the
nextjs
branch
from
2d308c5 to
6ffc127
Compare
ChristopherChudzicki
force-pushed
the
cc/analyze
branch
from
423eee0 to
7ca6369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Description (What does it do?)
This PR updates course-search-utils to provide an ESM and CJS output.
Our build will use the ESM output, which allows us to tree-shake the libraries used within
course-search-utils. (Primarily, remixicon).Important: Review with mitodl/course-search-utils#148
How can this be tested?
goodgreat.NODE_ENV=production yarn workspace main build/searchand/c/[channelType]/[name]is a bit bigger than the other routes, but not double, as it is onnextjsbranchANALYZE=trueto the command above to get the webpack analysis